[webkit-reviews] review granted: [Bug 174882] PDF page number indicator is very flashy when scrolling : [Attachment 316507] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 174882: PDF page number indicator is very flashy when scrolling
https://bugs.webkit.org/show_bug.cgi?id=174882

Attachment 316507: Patch

https://bugs.webkit.org/attachment.cgi?id=316507&action=review




--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 316507
  --> https://bugs.webkit.org/attachment.cgi?id=316507
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316507&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:743
> + at interface _UIBackdropViewSettings()

Needs a space before ().

> Source/WebKit/UIProcess/ios/WKPDFPageNumberIndicator.mm:69
> +    _backdropView = adoptNS([[_UIBackdropView alloc]
initWithSettings:backdropViewSettings]);

Looks like you need to declare -initWithSettings: in UIKitSPI.h.