[webkit-reviews] review denied: [Bug 174503] [ES] Add support finally to Promise : [Attachment 316481] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has denied GSkachkov
<gskachkov at gmail.com>'s request for review:
Bug 174503: [ES] Add support finally to Promise
https://bugs.webkit.org/show_bug.cgi?id=174503

Attachment 316481: Patch

https://bugs.webkit.org/attachment.cgi?id=316481&action=review




--- Comment #17 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 316481
  --> https://bugs.webkit.org/attachment.cgi?id=316481
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316481&action=review

Overall, looks good. I can r+ once the problems are fixed and tests are added
:)

> Source/JavaScriptCore/builtins/PromisePrototype.js:97
> +	   if (typeof onFinally !== "function")
> +	       @throwTypeError("onFinally is not a function");

This also should be `@assert(typeof onFinally === "function")`.

> Source/JavaScriptCore/builtins/PromisePrototype.js:121
> +	   if (typeof onFinally !== "function")
> +	       @throwTypeError("onFinally is not a function");

This also should be `@assert(typeof onFinally === "function")`.