[webkit-reviews] review granted: [Bug 174823] Uncaught Exception: undefined is not an object (evaluating 'this._memoryRow.value = Number.bytesToString(this._canvas.memoryCost)') : [Attachment 316489] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 26 16:13:57 PDT 2017


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 174823: Uncaught Exception: undefined is not an object (evaluating
'this._memoryRow.value = Number.bytesToString(this._canvas.memoryCost)')
https://bugs.webkit.org/show_bug.cgi?id=174823

Attachment 316489: Patch

https://bugs.webkit.org/attachment.cgi?id=316489&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 316489
  --> https://bugs.webkit.org/attachment.cgi?id=316489
Patch

r=me

Can you also remove the early return in _refreshIdentitySection? It seems
unnecessary given its only called in one place after the canvas was already
verified.


More information about the webkit-reviews mailing list