[webkit-reviews] review denied: [Bug 174861] WebDriver: fix return value of close window command : [Attachment 316445] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174861: WebDriver: fix return value of close window command
https://bugs.webkit.org/show_bug.cgi?id=174861

Attachment 316445: Patch

https://bugs.webkit.org/attachment.cgi?id=316445&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 316445
  --> https://bugs.webkit.org/attachment.cgi?id=316445
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316445&action=review

Absent a good justification, I don't want to add a redundant command. The web
service parts look good.

> Source/WebDriver/Session.cpp:308
> +void Session::continueGetWindowHandles(const InspectorObject& result,
Function<void (CommandResult&&)>&& completionHandler)

Nit: I prefer "fetchWindowHandles" or just "getWindowHandles".

> Source/WebKit/UIProcess/Automation/Automation.json:250
> +	       "returns": [

I don't like this. It's redundant with another command. Can you just compose
the two Automation commands in the service implementation? That's what
safaridriver does.