[webkit-reviews] review granted: [Bug 174870] Remove duplicate code from Buildbot.js in dashboard : [Attachment 316468] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 26 13:46:41 PDT 2017
Daniel Bates <dbates at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 174870: Remove duplicate code from Buildbot.js in dashboard
https://bugs.webkit.org/show_bug.cgi?id=174870
Attachment 316468: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=316468&action=review
--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 316468
--> https://bugs.webkit.org/attachment.cgi?id=316468
Proposed patch
View in context: https://bugs.webkit.org/attachment.cgi?id=316468&action=review
> Tools/ChangeLog:9
> + (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
Removing duplicate code and reusing buildPageURLForIteration() to construct
URL.
reusing => reuse
More information about the webkit-reviews
mailing list