[webkit-reviews] review granted: [Bug 174851] Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics : [Attachment 316453] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 174851: Add test to verify certain child processes are not launched as a
side effect of enabling ResourceLoadStatistics
https://bugs.webkit.org/show_bug.cgi?id=174851

Attachment 316453: Patch

https://bugs.webkit.org/attachment.cgi?id=316453&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 316453
  --> https://bugs.webkit.org/attachment.cgi?id=316453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316453&action=review

r=me with comment.

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:126
> +    EXPECT_EQ([sharedProcessPool _databaseProcessIdentifier], (pid_t)0);

The version of gtest we're using seems to still expect the expected value to
come first?

from gtest.h
#define EXPECT_EQ(expected, actual) ...