[webkit-reviews] review granted: [Bug 165714] WebAssembly: test throwing out of the start function : [Attachment 316452] patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted JF Bastien
<jfbastien at apple.com>'s request for review:
Bug 165714: WebAssembly: test throwing out of the start function
https://bugs.webkit.org/show_bug.cgi?id=165714

Attachment 316452: patch

https://bugs.webkit.org/attachment.cgi?id=316452&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 316452
  --> https://bugs.webkit.org/attachment.cgi?id=316452
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316452&action=review

r=me with comment.

> JSTests/wasm/function-tests/trap-from-start.js:48
> +    assert.throws(() => new WebAssembly.Instance(module, imp),
WebAssembly.RuntimeError, `Out of bounds memory access`);

Can we also get a version of this with instantiate?