[webkit-reviews] review granted: [Bug 174812] Clean up ExceptionCode enumeration : [Attachment 316372] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 174812: Clean up ExceptionCode enumeration
https://bugs.webkit.org/show_bug.cgi?id=174812

Attachment 316372: Patch

https://bugs.webkit.org/attachment.cgi?id=316372&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 316372
  --> https://bugs.webkit.org/attachment.cgi?id=316372
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316372&action=review

> Source/WebCore/Modules/indexeddb/shared/IDBError.h:38
> +    WEBCORE_EXPORT IDBError(std::optional<ExceptionCode> = std::nullopt,
const String& message = { });

I think that maybe this should be marked explicit.