[webkit-reviews] review granted: [Bug 174846] Remove Broken CompareEq constant folding phase. : [Attachment 316411] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 174846: Remove Broken CompareEq constant folding phase.
https://bugs.webkit.org/show_bug.cgi?id=174846

Attachment 316411: Patch

https://bugs.webkit.org/attachment.cgi?id=316411&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 316411
  --> https://bugs.webkit.org/attachment.cgi?id=316411
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316411&action=review

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:138
> +		   // FIXME: We should add back the broken folding phase here
for comparisions with thing we prove one side has type SpecOther. 

thing => things.

Also, please add bug URL or remove FIXME.