[webkit-reviews] review granted: [Bug 174842] Web Inspector: Don't output "No message" for multi-value logs like console.log(x, y) : [Attachment 316405] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 174842: Web Inspector: Don't output "No message" for multi-value logs like
console.log(x, y)
https://bugs.webkit.org/show_bug.cgi?id=174842

Attachment 316405: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=316405&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 316405
  --> https://bugs.webkit.org/attachment.cgi?id=316405
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=316405&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:476
> +		       }

I know it's only in two places, but a helper might be nice:

function createDivider() {
    let divider = document.createElement("span");
    divider.textContent = ` ${enDash} `;
    divider.classList.add("console-message-preview-divider");
    return divider;
}

if (needsDivider) {
    builderElement.appendChild(createDivider());