[webkit-reviews] review denied: [Bug 173883] [GCrypt] Key serialization support : [Attachment 315940] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has denied Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 173883: [GCrypt] Key serialization support
https://bugs.webkit.org/show_bug.cgi?id=173883

Attachment 315940: Patch

https://bugs.webkit.org/attachment.cgi?id=315940&action=review




--- Comment #12 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 315940
  --> https://bugs.webkit.org/attachment.cgi?id=315940
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315940&action=review

Thanks for taking my last comment. r- for the following reasons. Please address
it.

> Source/WebCore/crypto/gcrypt/SerializedCryptoKeyWrapGCrypt.cpp:44
>  bool wrapSerializedCryptoKey(const Vector<uint8_t>& masterKey, const
Vector<uint8_t>& key, Vector<uint8_t>& result)

I am suggesting you just return the key. Maybe a copy is needed. That's it.

The key here is already serialized. You don't have to do it again.