[webkit-reviews] review denied: [Bug 174829] Async image decoding can be enabled till the page milestone DidHitRelevantRepaintedObjectsAreaThreshold is reached : [Attachment 316384] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 174829: Async image decoding can be enabled till the page milestone
DidHitRelevantRepaintedObjectsAreaThreshold is reached
https://bugs.webkit.org/show_bug.cgi?id=174829

Attachment 316384: Patch

https://bugs.webkit.org/attachment.cgi?id=316384&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 316384
  --> https://bugs.webkit.org/attachment.cgi?id=316384
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316384&action=review

> Source/WebCore/page/Page.cpp:966
> +    static const double timeAfterDidFinishLoadToPaint = 0.5;

Seconds

> Source/WebCore/page/Page.cpp:1831
> +    if (m_timeResetRelevantPaintedObjectCounter &&
m_timeResetRelevantPaintedObjectCounter < currentTime())

MonotonicTime::now()

> Source/WebCore/page/Page.cpp:1943
> +bool Page::objectPaintRecrIntersectsRelevantPaintedRegion(const LayoutRect&
objectPaintRect) const

"RecrIntersects"

> Source/WebCore/page/Page.cpp:1945
> +    return
m_topRelevantPaintedRegion.intersects(snappedIntRect(objectPaintRect)) ||
m_bottomRelevantPaintedRegion.intersects(snappedIntRect(objectPaintRect));

Does this all work in iframes?

> Source/WebCore/page/Page.h:764
> +    double m_timeResetRelevantPaintedObjectCounter { 0 };

Please use Seconds or Monotonic time (I can't tell from the variable name if
this is a duration or an absolute time so it needs a better name).