[webkit-reviews] review granted: [Bug 174809] Fix bugs in probe code to change sp on x86, x86_64 and 32-bit ARM. : [Attachment 316347] proposed patch.

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 174809: Fix bugs in probe code to change sp on x86, x86_64 and 32-bit ARM.
https://bugs.webkit.org/show_bug.cgi?id=174809

Attachment 316347: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=316347&action=review




--- Comment #4 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 316347
  --> https://bugs.webkit.org/attachment.cgi?id=316347
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=316347&action=review

Does testmasm run on any bots?	Maybe it should!

> Source/JavaScriptCore/assembler/testmasm.cpp:321
> +void testProbeModifiesStackPointer(std::function<void*(ProbeContext*)>
computeModifiedStack)

Would WTF::Function work here?