[webkit-reviews] review granted: [Bug 174787] Icon loader error on startup : [Attachment 316375] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174787: Icon loader error on startup
https://bugs.webkit.org/show_bug.cgi?id=174787

Attachment 316375: Patch

https://bugs.webkit.org/attachment.cgi?id=316375&action=review




--- Comment #13 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 316375
  --> https://bugs.webkit.org/attachment.cgi?id=316375
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316375&action=review

> Source/WebKit/UIProcess/API/glib/WebKitIconLoadingClient.cpp:39
> +	   // WebCore can send non HTTP icons only when it doesn't find icons
in document and
> +	   // falls back to document-url/favicon.ico. We don't want non HTTP
icons in that case either.

This comment will be outdated soon and I likely won't know to update it.

You might just want to mention non-HTTP icons, full stop, and not reference the
default favicon case that exists today.