[webkit-reviews] review denied: [Bug 174818] WebAssembly: generate smaller binaries : [Attachment 316373] patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 174818: WebAssembly: generate smaller binaries
https://bugs.webkit.org/show_bug.cgi?id=174818

Attachment 316373: patch

https://bugs.webkit.org/attachment.cgi?id=316373&action=review




--- Comment #3 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 316373
  --> https://bugs.webkit.org/attachment.cgi?id=316373
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316373&action=review

> Source/JavaScriptCore/ChangeLog:10
> +	   1. Don't tier up small functions without loops.

We shouldn't do these kinds of heuristics.  BBQ is not meant to generate good
code even for small functions.	This could be leaving too much money on the
table.