[webkit-reviews] review granted: [Bug 174754] Web Inspector: add context menu item for taking a screenshot of a node : [Attachment 316357] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 174754: Web Inspector: add context menu item for taking a screenshot of a
node
https://bugs.webkit.org/show_bug.cgi?id=174754

Attachment 316357: Patch

https://bugs.webkit.org/attachment.cgi?id=316357&action=review




--- Comment #11 from Brian Burg <bburg at apple.com> ---
Comment on attachment 316357
  --> https://bugs.webkit.org/attachment.cgi?id=316357
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316357&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:213
> +		      
WebInspector.consoleLogViewController.appendConsoleMessage(consoleMessage);

Very nice, thanks.

> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:226
> +		   let filename = WebInspector.UIString("Screen Shot %s-%s-%s
at %s.%s.%s").format(...values);

Does .format do the right thing for %s? Hmm..