[webkit-reviews] review granted: [Bug 174815] [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename : [Attachment 316362] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174815: [GTK] TestWebKitAPI tests are no longer built since the WebKit2
rename
https://bugs.webkit.org/show_bug.cgi?id=174815

Attachment 316362: Patch

https://bugs.webkit.org/attachment.cgi?id=316362&action=review




--- Comment #2 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 316362
  --> https://bugs.webkit.org/attachment.cgi?id=316362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316362&action=review

> Tools/ChangeLog:10
> +	   ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT.
Also, all WebKit2 test paths were updated to
> +	   use WebKit dir, while the tests are still in WebKit2 directory. This
patch also removes

I think the patch is fine for fixing this issue now,

But I suggest to clarify on the bug of the rename if not applying the
webkit2->webkit and webkit->webkitlegacy renaming also on the directories
Tools/TestWebKitAPI/Tests was intentional or an overlook.