[webkit-reviews] review granted: [Bug 174788] [GTK] ASSERTION FAILED: client in WebKit::IconDatabase::setClient : [Attachment 316297] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 174788: [GTK] ASSERTION FAILED: client in WebKit::IconDatabase::setClient
https://bugs.webkit.org/show_bug.cgi?id=174788

Attachment 316297: Patch

https://bugs.webkit.org/attachment.cgi?id=316297&action=review




--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 316297
  --> https://bugs.webkit.org/attachment.cgi?id=316297
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316297&action=review

> Source/WebKit/UIProcess/API/glib/IconDatabase.cpp:192
> -    // We don't allow a null client, because we never null check it anywhere
in this code
> -    // Also don't allow a client change after the thread has already began
> +    // Don't allow a client change after the thread has already began

Yes, that comment was already not true, there are actually a lot of m_client
null checks. Maybe we can also remove the default client thing now that we
check it everywhere.