[webkit-reviews] review granted: [Bug 174451] Async image decoding for large images should be disabled after the first time a tile is painted : [Attachment 316236] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 174451: Async image decoding for large images should be disabled after the
first time a tile is painted
https://bugs.webkit.org/show_bug.cgi?id=174451

Attachment 316236: Patch

https://bugs.webkit.org/attachment.cgi?id=316236&action=review




--- Comment #30 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 316236
  --> https://bugs.webkit.org/attachment.cgi?id=316236
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316236&action=review

> Source/WebCore/platform/graphics/BitmapImage.cpp:221
> +	   LOG(Images, "BitmapImage::%s - %p - url: %s [++++++++++++++++++++ an
asynchronous decoded frame is available for drawing]", __FUNCTION__, this,
sourceURL().string().utf8().data());

I don't think this is a useful change.

> Source/WebCore/platform/graphics/BitmapImage.cpp:241
> +	       LOG(Images, "BitmapImage::%s - %p - url: %s
[+-+-+-+-+-+-+-+-+-+- an asynchronous decoded frame will used for synchronous
drawing]", __FUNCTION__, this, sourceURL().string().utf8().data());

+-+-+-+-+-+-+-+-+-+- and -------------------- strike me as the result of a
logging "arms race". Please don't commit them.

> Source/WebCore/platform/graphics/GraphicsLayerClient.h:81
> +    GraphicsLayerPaintTileFirstPaint 	   = 1 << 1,

I would call this GraphicsLayerPaintFirstTilePaint