[webkit-reviews] review denied: [Bug 167084] Web Inspector: capture async stack trace when workers/main context posts a message : [Attachment 316266] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has denied Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 167084: Web Inspector: capture async stack trace when workers/main context
posts a message
https://bugs.webkit.org/show_bug.cgi?id=167084

Attachment 316266: Patch

https://bugs.webkit.org/attachment.cgi?id=316266&action=review




--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 316266
  --> https://bugs.webkit.org/attachment.cgi?id=316266
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316266&action=review

I'm going to mark this as r- for now since the error cases are not tested.
There may be some churn to address comments in dependent patches. Other than
those two things, this change looks good.

> Source/JavaScriptCore/ChangeLog:8
> +

Nit: created

> Source/WebCore/inspector/InspectorInstrumentation.h:129
> +    static void didPostMessage(Frame*, TimerBase&, JSC::ExecState&);

Please make this name match the other method in the pair:
didDispatchPostMessage

> Source/WebCore/inspector/PageDebuggerAgent.cpp:207
> +

I don't know much about this didFailPostMessage case. Does this only happen
because of a security violation? What if you detach the iframe synchronously
after posting a message?

> LayoutTests/inspector/debugger/async-stack-trace.html:51
> +    });

You need to test the case where the postMessage fails.