[webkit-reviews] review granted: [Bug 174775] Handle case where line_numbers is None instead of an array of line numbers : [Attachment 316291] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 174775: Handle case where line_numbers is None instead of an array of line
numbers
https://bugs.webkit.org/show_bug.cgi?id=174775

Attachment 316291: Patch

https://bugs.webkit.org/attachment.cgi?id=316291&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 316291
  --> https://bugs.webkit.org/attachment.cgi?id=316291
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316291&action=review

> Tools/Scripts/webkitpy/style/filereader.py:115
> +	   if 'line_numbers' in kwargs and kwargs['line_numbers']:

Please check if we can simplify this to if kwargs.get('line_numbers'):

> Tools/Scripts/webkitpy/style/main_unittest.py:165
> +    def test_linter_added_file(self):

Nit: should this name be more descriptive?