[webkit-reviews] review granted: [Bug 174771] Make ExceptionCode a proper enumeration : [Attachment 316263] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 174771: Make ExceptionCode a proper enumeration
https://bugs.webkit.org/show_bug.cgi?id=174771

Attachment 316263: Patch

https://bugs.webkit.org/attachment.cgi?id=316263&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 316263
  --> https://bugs.webkit.org/attachment.cgi?id=316263
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316263&action=review

> Source/WebCore/Modules/fetch/FetchBody.h:52
> -    void formData(FetchBodyOwner&, Ref<DeferredPromise>&& promise) {
promise.get().reject(ExceptionCode { 0 }); }
> +    void formData(FetchBodyOwner&, Ref<DeferredPromise>&& promise) {
promise.get().reject(NoException); }

How about NOT_SUPPORTED_ERR instead?

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3574
> -	   ExceptionCode ec = 0;
> +	   ExceptionCode ec = NoException;

It would be nice to switch these to ExceptionOr<>.

> Source/WebKitLegacy/win/DOMCoreClasses.cpp:824
> -    WebCore::ExceptionCode ec = 0;
> +    WebCore::ExceptionCode ec = WebCore::NoException;

Is this dead code?

> Source/WebKitLegacy/win/WebView.cpp:6045
> -	   ExceptionCode ec = 0;
> +	   ExceptionCode ec = NoException;

Is this dead code?