[webkit-reviews] review granted: [Bug 174751] [Mac WK2] Fix null dereference in asynchronous NSTextInputClient methods when deallocating a WKWebView : [Attachment 316180] Close the page earlier
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jul 22 10:48:49 PDT 2017
Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 174751: [Mac WK2] Fix null dereference in asynchronous NSTextInputClient
methods when deallocating a WKWebView
https://bugs.webkit.org/show_bug.cgi?id=174751
Attachment 316180: Close the page earlier
https://bugs.webkit.org/attachment.cgi?id=316180&action=review
--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 316180
--> https://bugs.webkit.org/attachment.cgi?id=316180
Close the page earlier
Especially since we cannot create a regression test, we want to go beyond
fixing this bug and instead structure the code so the bug is highly unlikely to
ever return. I think it’s worth some further thought about how to do that after
this fix goes in.
More information about the webkit-reviews
mailing list