[webkit-reviews] review granted: [Bug 174731] Drag and Drop preview image for Twitter link is the wrong shape : [Attachment 316128] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Tim Horton <thorton at apple.com>'s request
for review:
Bug 174731: Drag and Drop preview image for Twitter link is the wrong shape
https://bugs.webkit.org/show_bug.cgi?id=174731

Attachment 316128: Patch

https://bugs.webkit.org/attachment.cgi?id=316128&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 316128
  --> https://bugs.webkit.org/attachment.cgi?id=316128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316128&action=review

> Source/WebCore/dom/Document.cpp:6568
> +    const auto& frameView = *view();

auto& frameView

> Source/WebCore/dom/Range.cpp:1181
> +	   for (const auto& rect : textRects) {

auto& rect

> Source/WebCore/dom/Range.cpp:1193
> +    for (const auto& rect : textRects)

auto& rect

> Source/WebCore/dom/Range.cpp:1834
> +		   for (const auto& quad : elementQuads)

auto& quad

> Source/WebCore/dom/Range.h:126
> +    WEBCORE_EXPORT FloatRect
absoluteBoundingRect(RespectClippingForTextRects =
RespectClippingForTextRects::No) const;

All RespectClippingForTextRects::No should turn into YES as the default value
at some point in the function.

> Source/WebCore/page/TextIndicator.cpp:322
> +	   for (const auto& rect : absoluteTextRects)

auto& rect