[webkit-reviews] review granted: [Bug 174724] Fail gracefully when xcrun fails in IOSSimulatorPort constructor : [Attachment 316120] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 21 14:34:29 PDT 2017
Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 174724: Fail gracefully when xcrun fails in IOSSimulatorPort constructor
https://bugs.webkit.org/show_bug.cgi?id=174724
Attachment 316120: Patch
https://bugs.webkit.org/attachment.cgi?id=316120&action=review
--- Comment #5 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 316120
--> https://bugs.webkit.org/attachment.cgi?id=316120
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=316120&action=review
> Tools/Scripts/webkitpy/port/ios_simulator.py:83
> + except:
ok. we should use "except ScriptError:"
More information about the webkit-reviews
mailing list