[webkit-reviews] review granted: [Bug 174662] [Win] Implement Authentication dialog in MiniBrowser : [Attachment 316007] Fix style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 21 14:07:19 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 174662: [Win] Implement Authentication dialog in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=174662

Attachment 316007: Fix style

https://bugs.webkit.org/attachment.cgi?id=316007&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 316007
  --> https://bugs.webkit.org/attachment.cgi?id=316007
Fix style

View in context: https://bugs.webkit.org/attachment.cgi?id=316007&action=review

iOS test failure unrelated

> Tools/MiniBrowser/win/ResourceLoadDelegate.cpp:40
> +extern HRESULT DisplayAuthDialog(std::wstring& username, std::wstring&
password);

This should go in a header


More information about the webkit-reviews mailing list