[webkit-reviews] review granted: [Bug 174699] Drop make_dom_exceptions.pl script that we only have DOMException : [Attachment 316106] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 174699: Drop make_dom_exceptions.pl script that we only have DOMException
https://bugs.webkit.org/show_bug.cgi?id=174699

Attachment 316106: Patch

https://bugs.webkit.org/attachment.cgi?id=316106&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 316106
  --> https://bugs.webkit.org/attachment.cgi?id=316106
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316106&action=review

> Source/WebCore/dom/ExceptionCodeDescription.h:37
> +#if ENABLE(INDEXED_DATABASE)
> +    IDBDatabaseExceptionType,
> +#endif

Is this staying for good? Or will this be merged later?

> Source/WebCore/inspector/WebInjectedScriptHost.cpp:30
> +#include "DOMException.h"
> +#include "JSDOMException.h"

Surprised we need both of these. I would have thought we would only need
JSDOMException.h