[webkit-reviews] review granted: [Bug 174703] Web Inspector: Avoid subclassing WebInspector.Object if we do not need to : [Attachment 316063] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 21 12:01:17 PDT 2017


Brian Burg <bburg at apple.com> has granted  review:
Bug 174703: Web Inspector: Avoid subclassing WebInspector.Object if we do not
need to
https://bugs.webkit.org/show_bug.cgi?id=174703

Attachment 316063: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=316063&action=review




--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 316063
  --> https://bugs.webkit.org/attachment.cgi?id=316063
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=316063&action=review

>>> Source/WebInspectorUI/UserInterface/Models/Probe.js:27
>>> +WebInspector.ProbeSample = class ProbeSample
>> 
>> r-, this class dispatches events.
> 
> Where? Probe does, but I don't see where ProbeSample does. Can you point it
out to me?

Oops, didn't see the second class. I recant!


More information about the webkit-reviews mailing list