[webkit-reviews] review granted: [Bug 174706] Noise when AudioChannel lengths don't match. : [Attachment 316068] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 174706: Noise when AudioChannel lengths don't match.
https://bugs.webkit.org/show_bug.cgi?id=174706

Attachment 316068: Patch

https://bugs.webkit.org/attachment.cgi?id=316068&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 316068
  --> https://bugs.webkit.org/attachment.cgi?id=316068
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316068&action=review

> Source/WebCore/ChangeLog:9
> +	   When AudioChannel lengths don't match, it don't do the copy. This
leaves uninitialized data in the audio buffer.

Nit: "it don't do the copy. This leaves uninitialized data in the audio
buffer." => "returning early leaves uninitialized data in the audio buffer."