[webkit-reviews] review granted: [Bug 174700] Get rid of WebCore IconDatabase code : [Attachment 316069] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 174700: Get rid of WebCore IconDatabase code
https://bugs.webkit.org/show_bug.cgi?id=174700

Attachment 316069: Patch

https://bugs.webkit.org/attachment.cgi?id=316069&action=review




--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 316069
  --> https://bugs.webkit.org/attachment.cgi?id=316069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316069&action=review

I mostly just looked at the green code. Obv. get EWS building.

> Source/WebCore/history/HistoryItem.cpp:-212
> -	   iconDatabase().releaseIconForPageURL(m_urlString);

This was all pretty nutty, happy to see it go

> Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:531
> +    // Add link icons they exist for this page, if we are archiving the
entire page.

Grammar problem here.

> Source/WebCore/loader/icon/IconLoader.cpp:65
> +    ResourceRequest resourceRequest =  m_url;

Too many spaces after the =