[webkit-reviews] review granted: [Bug 174691] Hook up ITP quirks to the needsSiteSpecificQuirks setting : [Attachment 316043] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 174691: Hook up ITP quirks to the needsSiteSpecificQuirks setting
https://bugs.webkit.org/show_bug.cgi?id=174691

Attachment 316043: Patch

https://bugs.webkit.org/attachment.cgi?id=316043&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 316043
  --> https://bugs.webkit.org/attachment.cgi?id=316043
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316043&action=review

> Source/WebCore/loader/ResourceLoadObserver.cpp:65
> +#if PLATFORM(IOS)
> +    UNUSED_PARAM(page);
> +
> +    // There is currently no way to toggle the needsSiteSpecificQuirks
setting on iOS so we always enable
> +    // the site-specific quirks on iOS.
> +    return true;
> +#else

It is really strange that this logic is here rather than in Settings.