[webkit-reviews] review granted: [Bug 153137] Implement document.elementsFromPoint : [Attachment 316006] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ali Juma
<ajuma at chromium.org>'s request for review:
Bug 153137: Implement document.elementsFromPoint
https://bugs.webkit.org/show_bug.cgi?id=153137

Attachment 316006: Patch

https://bugs.webkit.org/attachment.cgi?id=316006&action=review




--- Comment #29 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 316006
  --> https://bugs.webkit.org/attachment.cgi?id=316006
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316006&action=review

> Source/WebCore/dom/TreeScope.cpp:334
> +    std::optional<LayoutPoint> absolutePoint =
absolutePointIfNotClipped(documentScope(), clientPoint);

auto absolutePoint

> Source/WebCore/dom/TreeScope.cpp:338
> +    HitTestResult result(*absolutePoint);

absolutePoint.value()

> Source/WebCore/dom/TreeScope.cpp:385
> +    HitTestResult result(*absolutePoint);

absolutePoint.value()

> Source/WebCore/rendering/HitTestResult.h:48
> +    enum HitTestProgress {
> +	   StopHitTesting,
> +	   ContinueHitTesting
> +    };

enum class HitTestProgress { Stop, Continue };

OK to move this outside the class.

> Source/WebCore/rendering/svg/RenderSVGContainer.cpp:186
> +	       if (result.addNodeToListBasedTestResult(child->node(), request,
localPoint) == HitTestResult::StopHitTesting)
> +		   return true;

At some point we should convert nodeAtFloatPoint to return an enum as well.