[webkit-reviews] review granted: [Bug 174633] Web Automation: implicit navigations don't cause browsing context switch : [Attachment 315980] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174633: Web Automation: implicit navigations don't cause browsing context
switch
https://bugs.webkit.org/show_bug.cgi?id=174633

Attachment 315980: Patch

https://bugs.webkit.org/attachment.cgi?id=315980&action=review




--- Comment #8 from Brian Burg <bburg at apple.com> ---
Comment on attachment 315980
  --> https://bugs.webkit.org/attachment.cgi?id=315980
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315980&action=review

r+ with change

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:468
> +	   m_handleWebFrameMap.clear();

You need to clear m_webFrameHandleMap too, as they are inversed lookup tables.