[webkit-reviews] review denied: [Bug 174664] [CMake] Add --nobuild option to stop build after generating project files : [Attachment 315975] [PATCH] Add '--nobuild' option

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 20 08:35:55 PDT 2017


Konstantin Tokarev <annulen at yandex.ru> has denied Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 174664: [CMake] Add --nobuild option to stop build after generating project
files
https://bugs.webkit.org/show_bug.cgi?id=174664

Attachment 315975: [PATCH] Add '--nobuild' option

https://bugs.webkit.org/attachment.cgi?id=315975&action=review




--- Comment #3 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 315975
  --> https://bugs.webkit.org/attachment.cgi?id=315975
[PATCH] Add '--nobuild' option

View in context: https://bugs.webkit.org/attachment.cgi?id=315975&action=review

> Tools/Scripts/webkitdirs.pm:2177
> +    return determineIsNoBuild();

determineIsNoBuild();
return $isNoBuild;

Otherwise it will return undefined value when called second time


More information about the webkit-reviews mailing list