[webkit-reviews] review denied: [Bug 134393] curl: Don't try to close & move the downloaded file twice : [Attachment 315945] add changelog

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 134393: curl: Don't try to close & move the downloaded file twice
https://bugs.webkit.org/show_bug.cgi?id=134393

Attachment 315945: add changelog

https://bugs.webkit.org/attachment.cgi?id=315945&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 315945
  --> https://bugs.webkit.org/attachment.cgi?id=315945
add changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=315945&action=review

This is probably an improvement, but it's unclear what is going on here.  It's
certainly a lot more than preventing closing and downloading a file twice.

> Source/WebCore/platform/network/curl/CurlDownload.cpp:-60
> -    LockHolder locker(m_mutex);

There is a lot of mutex removal.  There is no explanation why.	That and maybe
other things should be separated into a different patch.

> Source/WebCore/platform/network/curl/CurlDownload.cpp:170
> +	   // @FIXME error handling may be required

@ is unlike the rest of our code base.