[webkit-reviews] review granted: [Bug 174642] [WebIDL] Remove custom bindings for CommandLineAPIHost : [Attachment 315830] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 174642: [WebIDL] Remove custom bindings for CommandLineAPIHost
https://bugs.webkit.org/show_bug.cgi?id=174642

Attachment 315830: Patch

https://bugs.webkit.org/attachment.cgi?id=315830&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 315830
  --> https://bugs.webkit.org/attachment.cgi?id=315830
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315830&action=review

> Source/WebCore/inspector/CommandLineAPIHost.idl:46
> +    DOMString databaseId(Database? database);
> +    DOMString storageId(Storage? storage);

We should be able to make these non-optional. We only call them with real
values (CommandLineAPIModuleSource.js calls to CommandLineAPIHost.databaseId
and CommandLineAPIHost.storageId).