[webkit-reviews] review requested: [Bug 141469] [GTK] Layout Test http/tests/media/hls/hls-progress.html is failing : [Attachment 315936] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 19 10:58:53 PDT 2017


Charlie Turner <cturner at igalia.com> has asked  for review:
Bug 141469: [GTK] Layout Test http/tests/media/hls/hls-progress.html is failing
https://bugs.webkit.org/show_bug.cgi?id=141469

Attachment 315936: Patch

https://bugs.webkit.org/attachment.cgi?id=315936&action=review




--- Comment #3 from Charlie Turner <cturner at igalia.com> ---
Created attachment 315936

  --> https://bugs.webkit.org/attachment.cgi?id=315936&action=review

Patch

Definitely a hack, but I don't believe there is any other approach. Modifying
the demuxer to handle this case isn't something upstream think is a good idea,
in fact they don't think buffering queries should ever work on HLS pipelines.
Also note that the percentage value is quite meaningless from the queue's
buffer. It's simply used to recognize a difference has been observed and
progress of some form is being made.


More information about the webkit-reviews mailing list