[webkit-reviews] review granted: [Bug 174628] [EME] Build failure with Clang-3.8 on InitDataRegistry.cpp : [Attachment 315917] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 19 09:37:31 PDT 2017


Zan Dobersek <zan at falconsigh.net> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 174628: [EME] Build failure with Clang-3.8 on InitDataRegistry.cpp
https://bugs.webkit.org/show_bug.cgi?id=174628

Attachment 315917: Patch

https://bugs.webkit.org/attachment.cgi?id=315917&action=review




--- Comment #6 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 315917
  --> https://bugs.webkit.org/attachment.cgi?id=315917
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315917&action=review

> Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp:45
> +    if (buffer.size() > UINT_MAX)

I think std::numeric_limits<unsigned>::max() would fit better, but up to you.


More information about the webkit-reviews mailing list