[webkit-reviews] review granted: [Bug 174406] Setting the minimum font size preference doesn’t affect absolute line-height values, so lines overlap : [Attachment 315865] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 174406: Setting the minimum font size preference doesn’t affect absolute
line-height values, so lines overlap
https://bugs.webkit.org/show_bug.cgi?id=174406

Attachment 315865: Patch

https://bugs.webkit.org/attachment.cgi?id=315865&action=review




--- Comment #34 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 315865
  --> https://bugs.webkit.org/attachment.cgi?id=315865
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315865&action=review

> Source/WebCore/css/StyleBuilderCustom.h:655
> +    auto result = style.specifiedFontSize();

I had to look at the code to see that this was a float. Auto harmful?

> Source/WebCore/css/StyleBuilderCustom.h:707
> +	   std::optional<Length> lineHeight =
StyleBuilderConverter::convertLineHeight(styleResolver, value, multiplier);

If multiplier is still 1, aren't you just calling
StyleBuilderConverter::convertLineHeight() with the same arguments as above,
and doing redundant work?

> Source/WebCore/css/StyleBuilderCustom.h:708
> +	   ASSERT(static_cast<bool>(lineHeight));

I would much rather read lineHeight != 0