[webkit-reviews] review granted: [Bug 173975] WTF::Thread should have the threads stack bounds. : [Attachment 315544] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 18 14:31:58 PDT 2017


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 173975: WTF::Thread should have the threads stack bounds.
https://bugs.webkit.org/show_bug.cgi?id=173975

Attachment 315544: Patch

https://bugs.webkit.org/attachment.cgi?id=315544&action=review




--- Comment #40 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 315544
  --> https://bugs.webkit.org/attachment.cgi?id=315544
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315544&action=review

r=me.  I'm going to do a local build and test on iOS to make sure that the
previously seen issues are truly resolved (and that there aren't any other
surprises).  Will let you know when all clear to land.	Thanks.

> Source/WTF/wtf/WTFThreadData.h:101
> +    StackStats::PerThreadStats m_stackStats { };

This is not needed.  It should be invoked by default.


More information about the webkit-reviews mailing list