[webkit-reviews] review granted: [Bug 174641] [Curl] Move detail implementation from ResourceHandle to ResourceHandleInternal : [Attachment 315824] PATCH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 18 14:05:16 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 174641: [Curl] Move detail implementation from ResourceHandle to
ResourceHandleInternal
https://bugs.webkit.org/show_bug.cgi?id=174641

Attachment 315824: PATCH

https://bugs.webkit.org/attachment.cgi?id=315824&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 315824
  --> https://bugs.webkit.org/attachment.cgi?id=315824
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=315824&action=review

I don't think ResourceHandleInternal should've ever been separated from
ResourceHandle.  They should've been one class.

Keep in mind, the end goal is to have all this networking code work with the
NetworkDataTask abstraction.  Carlos Garcia did something similar with lib soup
in these bugs, which were very heavily based on the asynchronous ResourceHandle
work.
https://bugs.webkit.org/show_bug.cgi?id=163597
https://bugs.webkit.org/show_bug.cgi?id=163777
https://bugs.webkit.org/show_bug.cgi?id=163939

> Source/WebCore/platform/network/ResourceHandleInternal.h:92
> +	   , m_handle { loader }

Ideally a ResourceHandleInternal wouldn't need to store a pointer to its
ResourceHandle, but whatevs.


More information about the webkit-reviews mailing list