[webkit-reviews] review granted: [Bug 173952] [GStreamer] Some layout tests issue "g_mutex_clear() called on uninitialised or locked mutex" and flaky crash in ~MediaPlayerPrivateGStreamerBase : [Attachment 315792] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Miguel Gomez
<magomez at igalia.com>'s request for review:
Bug 173952: [GStreamer] Some layout tests issue "g_mutex_clear() called on
uninitialised or locked mutex" and flaky crash in
~MediaPlayerPrivateGStreamerBase
https://bugs.webkit.org/show_bug.cgi?id=173952

Attachment 315792: Patch

https://bugs.webkit.org/attachment.cgi?id=315792&action=review




--- Comment #20 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 315792
  --> https://bugs.webkit.org/attachment.cgi?id=315792
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315792&action=review

Maybe Žan can have another look but you have r=me.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:17
4
> +    void triggerVolumeChangedNotification();
>      static void muteChangedCallback(MediaPlayerPrivateGStreamerBase*);
> +    void triggerMuteChangedNotification();

These two functions are called at the end of the callers, they are called only
once and have just one line (besides the lock) so I think you can inline them.