[webkit-reviews] review denied: [Bug 174542] [WinCairo] Provide timeout for WebSocket initial connection : [Attachment 315545] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 18 00:07:13 PDT 2017


Alex Christensen <achristensen at apple.com> has denied Karlen Simonyan
<szkarlen at gmail.com>'s request for review:
Bug 174542: [WinCairo] Provide timeout for WebSocket initial connection
https://bugs.webkit.org/show_bug.cgi?id=174542

Attachment 315545: Patch

https://bugs.webkit.org/attachment.cgi?id=315545&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 315545
  --> https://bugs.webkit.org/attachment.cgi?id=315545
Patch

I think we should instead make it so the connection succeeding calls a
callback, not waiting for the connection and not just setting a timeout of 20ms
for the connection.


More information about the webkit-reviews mailing list