[webkit-reviews] review granted: [Bug 174601] [JSC] There should be a debug option to dump a compiled RegExp Pattern : [Attachment 315747] Updated patch - replaced U_FALLTHROUGH with FALLTHROUGH

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 174601: [JSC] There should be a debug option to dump a compiled RegExp
Pattern
https://bugs.webkit.org/show_bug.cgi?id=174601

Attachment 315747: Updated patch - replaced U_FALLTHROUGH with FALLTHROUGH

https://bugs.webkit.org/attachment.cgi?id=315747&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 315747
  --> https://bugs.webkit.org/attachment.cgi?id=315747
Updated patch - replaced U_FALLTHROUGH with FALLTHROUGH

View in context: https://bugs.webkit.org/attachment.cgi?id=315747&action=review

> Source/JavaScriptCore/runtime/Options.h:435
> +    v(bool, dumpCompiledRegExpPatterns, false, Normal, nullptr) \

Would it be useful to make this an option, not a compile time flag?  Could you
use NDEBUG instead?

> Source/JavaScriptCore/yarr/YarrPattern.cpp:1004
> +

extra whitespace