[webkit-reviews] review granted: [Bug 174445] Add WebDriver support in browser driver part of BenchmarkRunner : [Attachment 315719] Patch

[bugzilla-daemon at webkit.org]

Stephanie Lewis <slewis at apple.com> has granted Matthew Stewart
<matthew_r_stewart at apple.com>'s request for review:
Bug 174445: Add WebDriver support in browser driver part of BenchmarkRunner
https://bugs.webkit.org/show_bug.cgi?id=174445

Attachment 315719: Patch

https://bugs.webkit.org/attachment.cgi?id=315719&action=review




--- Comment #6 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 315719
  --> https://bugs.webkit.org/attachment.cgi?id=315719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315719&action=review

Otherwise patch looks awesome!

> Tools/ChangeLog:8
> +	   *
Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:

This changelog is long enough that you should have a paragraph under the
reviewed bit describing in more detail what it does.  Also some minimal
annotation on the various functions to describe their purpose can be useful.