[webkit-reviews] review granted: [Bug 174585] [iOS DnD] Web process uses too much memory when beginning a drag on a very large image : [Attachment 315673] Rebase on master

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 17 13:54:39 PDT 2017


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 174585: [iOS DnD] Web process uses too much memory when beginning a drag on
a very large image
https://bugs.webkit.org/show_bug.cgi?id=174585

Attachment 315673: Rebase on master

https://bugs.webkit.org/attachment.cgi?id=315673&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 315673
  --> https://bugs.webkit.org/attachment.cgi?id=315673
Rebase on master

View in context: https://bugs.webkit.org/attachment.cgi?id=315673&action=review

> Source/WebCore/platform/ios/DragImageIOS.mm:103
> +	   auto scaledWidth = std::round(std::sqrt(maximumAllowedDragImageArea
* imageSize.width / imageSize.height));
> +	   adjustedImageScale = scaledWidth / imageSize.width;
> +	   imageSize = { scaledWidth, std::round(maximumAllowedDragImageArea /
scaledWidth) };

Is there a GeometryUtilities you could use here?


More information about the webkit-reviews mailing list