[webkit-reviews] review granted: [Bug 171327] Add attribute allow-top-navigation-by-user-activation to iframe sandbox : [Attachment 315246] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 171327: Add attribute allow-top-navigation-by-user-activation to iframe
sandbox
https://bugs.webkit.org/show_bug.cgi?id=171327

Attachment 315246: Patch

https://bugs.webkit.org/attachment.cgi?id=315246&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 315246
  --> https://bugs.webkit.org/attachment.cgi?id=315246
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315246&action=review

r=me

> Source/WebCore/dom/Document.cpp:3104
> +    // i. A frame can navigate its top ancestor when its
'allow-top-navigation' flag is set (sometimes known as 'frame-busting')

WebKit comments should end with a period.

> LayoutTests/ChangeLog:19
> +	   *
http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-ge
sture-2.html: Added.

Please add a test for when such navigation is NOT allowed.