[webkit-reviews] review granted: [Bug 174538] Search bar is moved up automatically when typing in baidu.com : [Attachment 315567] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 174538: Search bar is moved up automatically when typing in baidu.com
https://bugs.webkit.org/show_bug.cgi?id=174538

Attachment 315567: Patch

https://bugs.webkit.org/attachment.cgi?id=315567&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 315567
  --> https://bugs.webkit.org/attachment.cgi?id=315567
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315567&action=review

> Source/WebCore/page/FrameView.cpp:4912
> +    FloatSize clientOrigin = frame().settings().visualViewportEnabled() ?
-toFloatSize(layoutViewportRect().location()) :
-toFloatSize(visibleContentRect().location());

It is possible to rearrange this to duplicate less code between the conditions
:)

> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:510
> +    LOG_WITH_STREAM(Scrolling, stream << getpid() << "
AsyncScrollingCoordinator::reconcileViewportConstrainedLayerPositions for
viewport rect " << viewportRect);

Logging that goes to os_log usually gets the pid in one of the earlier
columns... I guess you're duplicating it here so it shows up if you're
attached/watching the console you launched from?