[webkit-reviews] review granted: [Bug 174567] Remove ancient immediate repaint hack in Element::setActive() : [Attachment 315610] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 16 12:58:40 PDT 2017


Wenson Hsieh <wenson_hsieh at apple.com> has granted Andreas Kling
<akling at apple.com>'s request for review:
Bug 174567: Remove ancient immediate repaint hack in Element::setActive()
https://bugs.webkit.org/show_bug.cgi?id=174567

Attachment 315610: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=315610&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 315610
  --> https://bugs.webkit.org/attachment.cgi?id=315610
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315610&action=review

LGTM, as long as there are no WebKit1 clients who still depend on this
codepath. We should make sure that this doesn't break media controls in the
Messages transcript, or links/buttons in iBooks.

> Source/WebCore/html/HTMLAnchorElement.h:80
> +    void setActive(bool active = true) final;

Can we just make this bool = true while we're at it?


More information about the webkit-reviews mailing list