[webkit-reviews] review granted: [Bug 174479] Make the decision for asynchronously decoding an image be in one place : [Attachment 315470] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 174479: Make the decision for asynchronously decoding an image be in one
place
https://bugs.webkit.org/show_bug.cgi?id=174479

Attachment 315470: Patch

https://bugs.webkit.org/attachment.cgi?id=315470&action=review




--- Comment #13 from Tim Horton <thorton at apple.com> ---
Comment on attachment 315470
  --> https://bugs.webkit.org/attachment.cgi?id=315470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315470&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:324
> +    if (IOSApplication::isIBooks())

Given recent discussions, this should be more specific (definitely about just
iBooks Storytime, but also possibly other details -- I'll show you the email
thread).

> Source/WebCore/rendering/RenderImage.cpp:588
> +    auto drawResult = paintInfo.context().drawImage(*img, rect,
ImagePaintingOptions(compositeOperator, BlendModeNormal,
decodingModeForImageDraw(*image, paintInfo), orientationDescription,
interpolation));

what is going on with "image" and "img" in this function? I hate it!